mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
128 stars 120 forks source link

[MM-53695] Make use of github.com/mattermost/mattermost/server/public #185

Closed hanzei closed 1 year ago

hanzei commented 1 year ago

Summary

This PR makes use of the newly created go module in https://pkg.go.dev/github.com/mattermost/mattermost/server/public.

I intentionally did updatemin_server_version as the plugin does still work with v7 servers.

Once https://github.com/mattermost/mattermost-plugin-api gets moved to the mono repo, I will update the plugin to make use of the pluginapi.Client and advocate for its usage over p.API.

I also snuck a go update to 1.19 into the PR. This gets the plugin in sync with the go version used in other plugins. CI is already updated.

Ticket Link

https://mattermost.atlassian.net/browse/MM-53695

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b874f47) 5.26% compared to head (e12ec05) 5.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #185 +/- ## ====================================== Coverage 5.26% 5.26% ====================================== Files 3 3 Lines 38 38 ====================================== Hits 2 2 Misses 36 36 ``` | [Impacted Files](https://app.codecov.io/gh/mattermost/mattermost-plugin-starter-template/pull/185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/main.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-starter-template/pull/185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL21haW4uZ28=) | `0.00% <ø> (ø)` | | | [server/plugin.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-starter-template/pull/185?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3BsdWdpbi5nbw==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.