search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
133 stars 121 forks source link

Add support for custom makefile #45

Closed hanzei closed 5 years ago

hanzei commented 5 years ago

This PR adds support for custom makefiles. The custom makefile must be located under build/custom.mk. I don't see the need for making this customisable. I've added a empty file as a boiler plate.

Please note that custom targets will not be listed via make help. I tried fixing this but it took to much time. I would open a Help Wanted ticket for this, if there are no objections.

alifarooq0 commented 5 years ago

Thanks @hanzei! Was just wondering what's the advantage of adding a boiler plate custom make file? Is it to set a pattern for whoever uses this as a starting point for building a plugin?

hanzei commented 5 years ago

Hey @marianunez and @ali-farooq0,

Sorry, I didn't made my intentions clear. Let me make up for this:

Plugin devs start of with a new plugin my copying this repo. The make changes to the go and react code base. Concurrently, this repository gets updated with e.g. new make targets. We currently don't have any tooling in place to update the Makfile. Hence, the only strategy is copy&past the update makefile from the repo. To make process more comfortable there should be "no merge conflicts". Ideally plugin devs should have no reason to "fork" Makefile. To accomplish this I want to encourage devs to move the custom changes like new targets or changed environment variables in this custom makefile.

Let me know what you think about this.

hanzei commented 5 years ago

Thanks for the feedback. I added a short comment about this.