search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
133 stars 121 forks source link

Add a task of webapp test #51

Closed kaakaa closed 5 years ago

kaakaa commented 5 years ago

Add a task for running webapp test.

hanzei commented 5 years ago

@marianunez Yes

kaakaa commented 5 years ago

Thank you for commenting @marianunez and @lieut-data.

I've fleshed out tests with hello-world plugin from developers document. Is this too much for template?

kaakaa commented 5 years ago

Thanks @lieut-data! It sounds good to make test cases more simple, and I've simplify it.

there's also a number of proposed dependency updates here.

I supposed that these updates are needed for running Jest. But I'm not familiar with Jest, so if there are any ways for running Jest without updates, please let me know it.

kaakaa commented 5 years ago

Thank you for reviewing @crspeller and @lieut-data! And sorry for my careless force push. I'll keep it in mind.

I've fixed the points that you reviewed, so please take a look again.