search

mattermost / mattermost-plugin-starter-template

Build scripts and templates for writing Mattermost plugins.
https://developers.mattermost.com/extend/plugins/
Apache License 2.0
129 stars 120 forks source link

fix for go 1.13 strictness #70

Closed cpoile closed 4 years ago

cpoile commented 4 years ago

I would love to know if there's a better fix than doing this for every plugin repo. But I guess not, since it's a bad import in server@5.12. @hanzei thoughts?

cpoile commented 4 years ago

@hanzei Not exactly, try changing it to 5.14.0+incompatible, 5.16.0+incompatible and 5.16.0 and see the errors. Things are a little messed up somewhere. @levb and I tried to figure it out last week, but didn't really get anywhere.

hanzei commented 4 years ago

Could you please double check? Since MM 5.16 we are using the latest version of github.com/willnorris/imageproxy with a correct date in the manifest. See https://github.com/mattermost/mattermost-server/commit/20825a17021ba61badfebc2bef34f49e5259a3c3#diff-37aff102a57d3d7b797f152915a6dc16R100

cpoile commented 4 years ago

@hanzei It's other things -- go can't even find 5.16.0+incompatible. That's why I'm suggesting you to try it out yourself, the errors are weird.

alifarooq0 commented 4 years ago

@cpoile @hanzei is this still applicable or should this be closed?

hanzei commented 4 years ago

We should bump the depencie to 5.16.X and use the hash.