Closed hanzei closed 6 years ago
The build archive could also be named $ID_$Version.tar.gz
.
This would make it easier to differ the version. Would this work for the server?
Thanks for the review! I understand that you want to keep things consistent. If we follow this thought we should use one file for both web and server e.g. manifest.js
and manifest.go
or two files for both web and server e.g. plugin_version.js
and plugin_id.js
and plugin_id. go
and plugin_version.go
.
I would rather go with one file per plugin part.
@Hanzei, I think a generated manifest.(js|go)
probably makes a lot of sense!
Thanks for the reviews. I addressed the feedback.
I also change the makefile to include the plugins version, e.g. com.mattermost.sample-plugin_0.0.1.tar.gz
@Hanzei would you mind copying these changes to https://github.com/mattermost/mattermost-plugin-demo as well?
@jwilander sure, I can do this
This allows for e.g. log messenger when the plugin starts with the current version.
I have no experience in js. Should similar changes be made to
plugin_id.js
?