Closed AugustasV closed 2 years ago
Hello @AugustasV,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Merging #250 (0db65b7) into master (8a5a54d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #250 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 8 8
Lines 900 900
======================================
Misses 900 900
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8a5a54d...0db65b7. Read the comment docs.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @aspleenic
@mickmister
The image isn't displaying in the preview because it hasn't been merged. I'll need to check this in prod.
ping for this, @larkox. :)
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@AugustasV Sorry for the confusion. My idea was more in the line of a screenshot like this one (used on older versions of the readme), but updated with the latest UI.
Also, with the work @mickmister is doing with the App Bar, this UI may soon change again.
@mickmister Do you think we should close this PR and wait for the App Bar to be in place to add the screenshot? Or do you see value on adding this now, and update it later?
@larkox The Zoom icon will actually be going to the Start Call Button like the Calls plugin. 2/5 we should close this, as it will soon be an outdated screenshot. Along with this, we'll need to update individual plugin docs like this when we roll out the App Bar and Start Call Button changes. cc @cwarnermm @justinegeffen
Thanks for confirming. I am really sorry @AugustasV for all the confusion. Thank you very much for contributing, and we hope you contribute in other parts of the product.
167 Adding screenshot of zoom plugin to repo README.md file.
Signed-off-by: AugustasV reg1nt1z@gmail.com