mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[GH-244] Update autocomplete help summary #251

Closed jeromegrosse closed 1 year ago

jeromegrosse commented 2 years ago

Summary

Update the auto-complete commands. In particular, states that the meeting topic argument is optional. The update is performed both in auto-complete themselves as well as the text returned by help.

Autocomplete Help Output
image image
In addition, the general autocomplete description reflects the plugin and user capabilities to connect/disconnect: Can Connect Cannot Connect
image image

Ticket Link

Fixes https://github.com/mattermost/mattermost-plugin-zoom/issues/244

mattermod commented 2 years ago

Hello @jeromegrosse,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov[bot] commented 2 years ago

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:

Coverage data is based on head (917c394) compared to base (a6c01ce). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #251 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 8 8 Lines 906 911 +5 ====================================== - Misses 906 911 +5 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/command.go](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/251/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2NvbW1hbmQuZ28=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeromegrosse commented 2 years ago

@hanzei, sure! I'll do my best to update the PR today.

jeromegrosse commented 2 years ago

So, there's actually already a method in that very file that checks for the condition: func (p *Plugin) canConnect(user *model.User) bool. This method depends on a User object pointer. I've thought of using it with canConnect(nil) and check within that method if user != nil. However, I don't find it super explicit. What do you all think?

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

mattermod commented 2 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @aspleenic

dipak-demansol commented 2 years ago

@jeromegrosse As Per The Description When i'm Disconnected then i'm Expecting this image

But i'm still getting command like this image

mickmister commented 2 years ago

@dipak-demansol The plugin's command autocomplete API is not able to change those descriptions per-user, so it will need to stay this way

hanzei commented 2 years ago

@jeromegrosse Sorry for the delay on your PR. Would you be open on merging master into your branch? Then your PR can get merged.

mattermod commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

jeromegrosse commented 1 year ago

Sorry for the late reply. Let me set again the plugin on my machine and I'll solve the conflicts.

hanzei commented 1 year ago

Aweseome, thank you very much for the contribution @jeromegrosse