Closed jeromegrosse closed 1 year ago
Hello @jeromegrosse,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Base: 0.00% // Head: 0.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
917c394
) compared to base (a6c01ce
). Patch coverage: 0.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@hanzei, sure! I'll do my best to update the PR today.
So, there's actually already a method in that very file that checks for the condition: func (p *Plugin) canConnect(user *model.User) bool
.
This method depends on a User object pointer. I've thought of using it with canConnect(nil)
and check within that method if user != nil
. However, I don't find it super explicit.
What do you all think?
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @aspleenic
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
/cc @aspleenic
@jeromegrosse As Per The Description When i'm Disconnected then i'm Expecting this
But i'm still getting command like this
@dipak-demansol The plugin's command autocomplete API is not able to change those descriptions per-user, so it will need to stay this way
@jeromegrosse Sorry for the delay on your PR. Would you be open on merging master
into your branch? Then your PR can get merged.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
Sorry for the late reply. Let me set again the plugin on my machine and I'll solve the conflicts.
Aweseome, thank you very much for the contribution @jeromegrosse
Summary
Update the auto-complete commands. In particular, states that the
meeting topic
argument is optional. The update is performed both in auto-complete themselves as well as the text returned byhelp
.Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-zoom/issues/244