mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[GH-240]:Fixed issue #240 edited the pretext of custom post #287

Closed Kshitij-Katiyar closed 10 months ago

Kshitij-Katiyar commented 1 year ago

Summary

Issue

mattermost-build commented 1 year ago

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f50692b) 19.33% compared to head (582b298) 19.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #287 +/- ## ======================================= Coverage 19.33% 19.33% ======================================= Files 9 9 Lines 1479 1479 ======================================= Hits 286 286 Misses 1138 1138 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hanzei commented 1 year ago

/update-branch

mattermost-build commented 1 year ago

We don't have permissions to update this PR, please contact the submitter to apply the update.

Kshitij-Katiyar commented 1 year ago

/update-branch

@hanzei synced with master

mattermost-build commented 1 year ago

We don't have permissions to update this PR, please contact the submitter to apply the update.

mattermost-build commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 11 months ago

@AayushChaudhary0001 Can you please review this PR?

mickmister commented 11 months ago

To render the markdown using the webapp's markdown logic, we can use the webapp's exposed functions formatText and messageHtmlToComponent

https://github.com/mattermost/mattermost-plugin-ai/blob/6f5c45ccbf3bb262fb6710bdc6a08838ff47e5cc/webapp/src/components/post_text.tsx#L43-L47

    const text = messageHtmlToComponent(
        formatText(props.message, markdownOptions),
        true,
        messageHtmlToComponentOptions,
    );

    return (
        <div>
            {text}
        </div>
    );
avas27JTG commented 10 months ago

@hanzei @Kshitij-Katiyar Tested this PR, working fine for text messages, but not supporting emoji's and GiF's if added in the message image

image

@AayushChaudhary0001 this has been fixed.

hanzei commented 10 months ago

@Kshitij-Katiyar Please merge master into your PR