search

mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

Release 1.6.2 #292

Closed mickmister closed 1 year ago

mickmister commented 1 year ago

Summary

Ticket Link

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 58.75% and project coverage change: +1.78 :tada:

Comparison is base (9d5a119) 21.89% compared to head (8ab42cf) 23.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.6.2 #292 +/- ## ================================================= + Coverage 21.89% 23.68% +1.78% ================================================= Files 8 9 +1 Lines 877 1157 +280 ================================================= + Hits 192 274 +82 - Misses 641 834 +193 - Partials 44 49 +5 ``` | [Impacted Files](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/configuration.go](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2NvbmZpZ3VyYXRpb24uZ28=) | `25.24% <ø> (-0.37%)` | :arrow_down: | | [server/http.go](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2h0dHAuZ28=) | `20.27% <0.00%> (-7.59%)` | :arrow_down: | | [server/webhook.go](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/292?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3dlYmhvb2suZ28=) | `59.11% <59.11%> (ø)` | | ... and [4 files with indirect coverage changes](https://codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/292/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

larkox commented 1 year ago

Why this PR has more changes than the usual bumping of the version?

mickmister commented 1 year ago

Why this PR has more changes than the usual bumping of the version?

@larkox If we were releasing off of master, we would just be bumping the version and nothing else, but we are instead creating a dot release off of the previous release to minimize the changes and testing required for this release.

Having all of this in the same PR lets us see what we're releasing, and gives @dhaussermann a specific build to use for testing. There are some changes necessary for CI here as well.

mickmister commented 1 year ago

@DHaussermann This PR is ready for QA review. Note that it essentially contains only the webhook validation fix