mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[GH-283]: Fixed issue #283 'Removed the code for depreciated JWT' #299

Closed Kshitij-Katiyar closed 10 months ago

Kshitij-Katiyar commented 1 year ago

Summary

mattermost-build commented 1 year ago

Hello @Kshitij-Katiyar,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

codecov[bot] commented 1 year ago

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (598725e) 19.92% compared to head (f888800) 19.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #299 +/- ## ========================================== - Coverage 19.92% 19.33% -0.59% ========================================== Files 9 9 Lines 1511 1479 -32 ========================================== - Hits 301 286 -15 + Misses 1155 1138 -17 Partials 55 55 ``` | [Files](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/plugin.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3BsdWdpbi5nbw==) | `33.76% <ø> (+9.52%)` | :arrow_up: | | [server/telemetry.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL3RlbGVtZXRyeS5nbw==) | `0.00% <ø> (-33.34%)` | :arrow_down: | | [server/command.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2NvbW1hbmQuZ28=) | `19.33% <33.33%> (+5.78%)` | :arrow_up: | | [server/configuration.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2NvbmZpZ3VyYXRpb24uZ28=) | `26.19% <0.00%> (+0.94%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattermost-build commented 1 year ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

hanzei commented 11 months ago

@mgdelacroix I'm going to remove you from the reviewers list as you seem too busy to review it currently.

hanzei commented 11 months ago

@Kshitij-Katiyar Heads up that there is a merge conflict to resolve

hanzei commented 11 months ago

@DHaussermann Ready for your review

mickmister commented 10 months ago

Note that we've merged a PR https://github.com/mattermost/mattermost-plugin-zoom/pull/310 that removes JWT from the readme, which had some merge conflicts here

avas27JTG commented 10 months ago

Fixes https://github.com/mattermost/mattermost-plugin-zoom/issues/283

AayushChaudhary0001 commented 10 months ago

Tested and Approved

This PR is tested for the following scenarios:-

All changes seems fine and are working perfect, LGTM