Closed Kshitij-Katiyar closed 10 months ago
Hello @Kshitij-Katiyar,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
598725e
) 19.92% compared to head (f888800
) 19.33%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!
@mgdelacroix I'm going to remove you from the reviewers list as you seem too busy to review it currently.
@Kshitij-Katiyar Heads up that there is a merge conflict to resolve
@DHaussermann Ready for your review
Note that we've merged a PR https://github.com/mattermost/mattermost-plugin-zoom/pull/310 that removes JWT from the readme, which had some merge conflicts here
Tested and Approved
This PR is tested for the following scenarios:-
All changes seems fine and are working perfect, LGTM
Summary
Zoom has depreciated its JWT authentication offering so we have also formally deprecated the JWT offering and removed it from the code.
Issue #283