mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[GH-300]: Fixed the JS error while posting meeting link to thread view #307

Closed Kshitij-Katiyar closed 10 months ago

Kshitij-Katiyar commented 11 months ago

Summary

Fixed the JS error which was caused while viewing a thread in the Threads view of the zoom plugin.

What to test?

Steps to reproduce
  1. Have CRT enabled, and open the Threads view
  2. Open a thread that pops into the RHS
  3. Click the Zoom button on the right
Environment:

MM version: v7.8.2 Node version: 14.18.0 Go version: 1.19.0

Ticket Link

Fixes #300

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cd9bb0b) 19.33% compared to head (bc9a9c1) 23.51%.

:exclamation: Current head bc9a9c1 differs from pull request most recent head 36af3a7. Consider uploading reports for the commit 36af3a7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #307 +/- ## ========================================== + Coverage 19.33% 23.51% +4.17% ========================================== Files 9 9 Lines 1479 1212 -267 ========================================== - Hits 286 285 -1 + Misses 1138 874 -264 + Partials 55 53 -2 ``` | [Files](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost) | Coverage Δ | | |---|---|---| | [server/http.go](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/307?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost#diff-c2VydmVyL2h0dHAuZ28=) | `20.00% <50.00%> (+14.81%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/mattermost/mattermost-plugin-zoom/pull/307/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mattermost)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.