search

mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

Bump version v2.0.0 (closed, renamed to v1.7.0) #321

Closed avas27JTG closed 9 months ago

avas27JTG commented 10 months ago

Summary

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ba2d98c) 19.33% compared to head (2d70109) 19.33%. Report is 1 commits behind head on master.

:exclamation: Current head 2d70109 differs from pull request most recent head 8b95f53. Consider uploading reports for the commit 8b95f53 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #321 +/- ## ======================================= Coverage 19.33% 19.33% ======================================= Files 9 9 Lines 1479 1479 ======================================= Hits 286 286 Misses 1138 1138 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 10 months ago

Looking at the PR description, I don't think all of those PRs are new to this release. For instance, these two have definitely been released, and many more:

The process of determining what's in the new release is a bit of a manual process when we have the dot release cherry-picking process that we have. It doesn't need to be 100% accurate since this is difficult to verify, but try your best to pick out the work that is specific to this release. Essentially things that have built up on master that we didn't end up ever dot releasing, which I know is difficult because of the many different ways different people may have organized those commits when preparing the dot releases. What is usually built up in the master branch are non-urgent features and low impact defects.

Also, why is this specifically v2.0.0 and not a minor or dot release?

mickmister commented 10 months ago

To be more clear, here are the definitions to use to follow semantic version, or "semver":

https://semver.org

Given a version number Major.Minor.Patch, increment the:

Major - version when you make incompatible API changes Minor - version when you add functionality in a backward compatible manner Patch - version when you make backward compatible bug fixes

Additional labels for pre-release and build metadata are available as extensions to the Major.Minor.Patch format.

In our case this typically means:

In this case of this release, it will probably be a minor release, since I think there are new features here, and probably not any intentional breaking changes

avas27JTG commented 10 months ago

Yeah I agree with you @mickmister the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin https://github.com/mattermost/mattermost-plugin-zoom/pull/299

Please let me know if we should create the release as 1.7.0 or 2.0.0 considering above change?

avas27JTG commented 10 months ago

@mickmister I've updated the description after removing the issues/PRs which were released in previous releases.

mickmister commented 10 months ago

the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin https://github.com/mattermost/mattermost-plugin-zoom/pull/299

@avas27JTG That deprecation is really more of a deprecation from Zoom, and not so much our software. AFAIK the JWT offering doesn't work at all anymore on Zoom plugin version. Because of that, I don't think we should treat the new release as a breaking change in that regard. I think we should go with 1.7.0 for this release

mickmister commented 10 months ago

I removed some more from the list that are more clerical work, or have already been released. I think this may be more accurate:

avas27JTG commented 9 months ago

the only reason we were thinking of making it a major release was due to removal of the deprecated JWT settings from the plugin #299

@avas27JTG That deprecation is really more of a deprecation from Zoom, and not so much our software. AFAIK the JWT offering doesn't work at all anymore on Zoom plugin version. Because of that, I don't think we should treat the new release as a breaking change in that regard. I think we should go with 1.7.0 for this release

Sounds good, thanks for clarifying.

avas27JTG commented 9 months ago

@mickmister created a new PR https://github.com/mattermost/mattermost-plugin-zoom/pull/322 as I also changed the branch name to release-bump-1.7.0 in place of ...-2.0.0.