Bump version v1.7.0. - Githubissues

avas27JTG commented 9 months ago

Summary

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e8dfd09) 18.41% compared to head (b0adf26) 18.41%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #322 +/- ## ======================================= Coverage 18.41% 18.41% ======================================= Files 9 9 Lines 1515 1515 ======================================= Hits 279 279 Misses 1185 1185 Partials 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mickmister commented 9 months ago

The PR says it's out of date with the master branch

mickmister commented 8 months ago

/update-branch

mattermost-build commented 8 months ago

We don't have permissions to update this PR, please contact the submitter to apply the update.

arush-vashishtha commented 8 months ago

While performing the sanity testing I found an issue related to the limit in the Meeting topic while creating a meeting through the slash command /zoom start <meeting topic> for a very long meeting topic in any desired channel or DM/GM on MM.

Steps to reproduce: Run the slash command /zoom start <meeting topic> with a very long meeting topic in any desired channel or DM/GM on MM.

Expected result: The Zoom meeting should be created for very long meeting topic.

Actual result: Zoom meeting is not created for very long meeting topic.

cc @raghavaggarwal2308 @AayushChaudhary0001

arush-vashishtha commented 8 months ago

This PR have been tested for all the PRs included, the basic flows and slash commands in the above mentioned list and they are working fine. Nonetheless found another issue regarding the "emojis" added to the meeting topic in the slash command /zoom start <meeting topic>.

Steps to Reproduce: Run the slash command /zoom start <meeting topic> in any desired channel or DM/GM on MM and add emojis in the meeting topic.

Expected result: The emoji should render properly in the meeting topic on slack attachment for the new meeting in the desired channel or DM/GM on MM.

Actual result: The emoji name is being displayed in the meeting topic instead of the emoji in the desired channel or DM/GM on MM.

cc @raghavaggarwal2308 @AayushChaudhary0001

raghavaggarwal2308 commented 8 months ago

While performing the sanity testing I found an issue related to the limit in the Meeting topic while creating a meeting through the slash command /zoom start <meeting topic> for a very long meeting topic in any desired channel or DM/GM on MM.

Steps to reproduce: Run the slash command /zoom start <meeting topic> with a very long meeting topic in any desired channel or DM/GM on MM.

Expected result: The Zoom meeting should be created for very long meeting topic.

Actual result: Zoom meeting is not created for very long meeting topic.

cc @raghavaggarwal2308 @AayushChaudhary0001

@arush-vashishtha I don't think this issue is related to any of the PR created in this release. Can you please create a separate issue for this? We can pick this up in an upcoming release.

arush-vashishtha commented 7 months ago

@arush-vashishtha I don't think this issue is related to any of the PR created in this release. Can you please create a separate issue for this? We can pick this up in an upcoming release.

A separate issue has been created, please look into it. https://github.com/mattermost/mattermost-plugin-zoom/issues/336

mickmister commented 7 months ago

@raghavaggarwal2308 The PR got closed since the issue was linked in the PR description, even though it was linked to comment

CleanShot 2024-01-29 at 21 18 42

mickmister commented 7 months ago

@avas27JTG Heads up that the PR needs to be sync'd with master

mattermost / mattermost-plugin-zoom

Bump version v1.7.0. #322

Summary

Codecov Report