mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[MI-3765] Fix issue: "Create New Meeting" button not working in threads view #325

Closed raghavaggarwal2308 closed 9 months ago

raghavaggarwal2308 commented 9 months ago

Summary

In the threads view on MM, when we were clicking the "Create New Meeting" button, no new meeting was getting created because of missing "RootID" while calling the "startMetting" function. We fixed the issue the sending the root ID present in the props.

What to test?

Steps to reproduce:
  1. Connect your Zoom account.
  2. Have CRT (Collapsed Reply Threads) enabled, and open the Threads view.
  3. Open a thread that pops into the RHS.
  4. Start a new meeting by clicking the Zoom button on the right.
  5. Without ending the meeting started, try to start a new meeting again.
  6. Click on the "Create New Meeting" button.
Expected behavior:
Environment:

MM version: v9.2.2 Node version: 14.18.0 Go version: 1.20.11

Ticket Link

Fixes #317

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (18da1f1) 19.33% compared to head (ed82ffa) 19.33%. Report is 1 commits behind head on master.

:exclamation: Current head ed82ffa differs from pull request most recent head 7d6f314. Consider uploading reports for the commit 7d6f314 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #325 +/- ## ======================================= Coverage 19.33% 19.33% ======================================= Files 9 9 Lines 1479 1479 ======================================= Hits 286 286 Misses 1138 1138 Partials 55 55 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.