Closed mickmister closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d9e6123
) 18.86% compared to head (1a5559d
) 18.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
With regards to the image references in the README, none of them seem to be referencing the checked-in images directly. I'm going to convert the ones being used into checked-in files, and get rid of any checked-in files that are not being referenced in the repository.
I don't want to complicate this PR though. This is meant to unblock the RC build issue
@mickmister We have created PR against the master to fix the failing CI here. We can sync this PR once that is merged. https://github.com/mattermost/mattermost-plugin-zoom/pull/332
@mickmister We have created PR against the master to fix the failing CI here. We can sync this PR once that is merged. #332
I've done this
Summary
The asset name
zoom-plugin-configuration.png
was causing issues with thecutplugin
command, likely because it contains the word "plugin". This PR changes the image name to avoid this conflict.I don't see where this file (or other files from the
assets
folder) are being used. I see links in the README like https://github.com/mattermost/mattermost-plugin-zoom/assets/74422101/3928708d-8b57-474b-9c4a-d1e21c054d31 that seem to reference images in theassets
folder, though I don't know how to verify which file it's accessing, and I don't know if I will break anything by renaming/removing images files. I don't see the name of the filezoom-plugin-configuration.png
(or most of the files in theassets
folder) being used anywhere in the repo, so it seems there is nothing using it but I'm not sure.Ticket Link
Fixes https://mattermost.atlassian.net/browse/CLD-6689