[GH-109] Update the meeting post and send DM to host when users joined meeting before host

[raghavaggarwal2308]

Summary

• Update the meeting post and send a DM to the host when users join the meeting before the host.

Screenshots

Custom post in channel:

Slack attachment in channel: DM message:

What to test?

• The host is getting a DM from the Zoom bot when the user(s) joined the meeting before him.
• The meeting post is updated in the channel if the users join the meeting before the host.

Note: Check for custom posts and Slack attachments (Slack attachments if displayed in the mobile app or when the plugin is disabled).

Steps to reproduce:

Note: Ensure you have added the "Participant was waiting for host to join", "Participant joined meeting before host" and "Participant/Host joined meeting" webhook events on your Zoom app.

1. Connect your Zoom account.
2. Create a meeting in any channel. (Do not join the meeting)
3. Join the meeting using another MM user.

Ticket Link

Fixes #109

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 1.43541% with 206 lines in your changes missing coverage. Please review.

Project coverage is 16.41%. Comparing base (d73eafa) to head (f22abf2). Report is 8 commits behind head on master.

:exclamation: Current head f22abf2 differs from pull request most recent head 395ca62

Please upload reports for the commit 395ca62 to get more accurate results.

Files	Patch %	Lines
server/http.go	0.00%	104 Missing :warning:
server/webhook.go	0.00%	80 Missing :warning:
server/store.go	0.00%	14 Missing :warning:
server/command.go	27.27%	8 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #334 +/- ## ========================================== - Coverage 18.04% 16.41% -1.64% ========================================== Files 9 9 Lines 1546 1718 +172 ========================================== + Hits 279 282 +3 - Misses 1216 1385 +169 Partials 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[mickmister]

@matthewbirtch What are your thoughts on this feature? I'm thinking we should make this a configurable user setting, though not sure if it should be opt-in or opt-out

[matthewbirtch]

@mickmister I think it's a cool idea - I agree that we should provide a way to opt out of this in the zoom plugin settings. "For meetings I host, notify me when participants join before me".

I like the "X participants waiting for the host", but I'm not sure we need the "Host is already in the meeting" added to the Zoom meeting post. Seems unnecessary to me.

[raghavaggarwal2308]

@mickmister Just for clarification:

1. We need to add a per-user setting (like in the /zoom setting command) to disable the DM notification. (Default value : true)
2. We need to remove "Host is already in the meeting" displayed on the meeting post.

[raghavaggarwal2308]

@mickmister Just for clarification:

1. We need to add a per-user setting (like in the /zoom setting command) to disable the DM notification. (Default value : true)
2. We need to remove "Host is already in the meeting" displayed on the meeting post.

@mickmister Gentle reminder for this

[mickmister]

@raghavaggarwal2308 Yes sounds good :+1: Can we also change "participants(s)" to adapt as "participant" and "participants"?

[raghavaggarwal2308]

@mickmister Just for clarification:

1. We need to add a per-user setting (like in the /zoom setting command) to disable the DM notification. (Default value : true)
2. We need to remove "Host is already in the meeting" displayed on the meeting post.

@mickmister @matthewbirtch Updated the PR with these changes

[mickmister]

Also there are some merge conflicts to resolve here

[matthewbirtch]

what's the best way for me to test the ux here @mickmister?

[mickmister]

Thanks @matthewbirtch

@raghavaggarwal2308 Are you able to have this running on a cloud server for testing?

[raghavaggarwal2308]

@mickmister Fixed the review comments added by you. Also, I have setup the zoom plugin on a cloud server. Please refer this

[matthewbirtch]

@raghavaggarwal2308 I've got things working properly, but a few notes from my testing:

• Joining Zoom via browser seems to be updating the post, but joining via Zoom's desktop app does not
• Once I join and then leave, the post doesn't get updated - still says 1 participant waiting for host.
• If I have >1 participant joining, that also does not seem to be reflected properly in the post. It still says '1 participant waiting for host'
• Also, if a second participant joins, I don't seem to be getting notified in a DM. Is that by design so we don't over notify the host? Maybe that makes sense. If it's a big meeting I could see this being quite annoying if a lot of people join before you. Maybe we keep it so it notifies you only about the first participant, but just wanted to understand the logic here.
• I'm not really sure how this happened, but I randomly got a notification from the Zoom bot **** has joined the meeting before you. Is this some sort of fallback? Unfortunately I can't see to reproduce this so I don't have more info.
• Can we make some text changes:
  • 1 participant is waiting for the host to join (don't use participant(s))
  • X participants are waiting for the host to join (don't use participant(s))
  • The host has joined the meeting

[raghavaggarwal2308]

@matthewbirtch Few replies/clarification from above comment:

1. The post should update whenever a user joins the meeting, not sure why its not updating for you.

2. The host get notified everytime a user joined the meeting before him.

   • There must be some issue because of which you are not getting the webhook from Zoom on joining with second user and hence you are not getting notified and post is not getting updated. I will see If I can reproduce the issue
   • Also, @mickmister had a suggesting about multiple DMs here

3. The host has joined the meeting: We added the logic to show a similar message when we created the PR but it was remove later because of this comment. Please let us know if we should add it back.

[matthewbirtch]

• Also, @mickmister had a suggesting about multiple DMs here

I'm concerned about notifying for every single participant that joins - especially for large meetings. I like the idea @mickmister had of updating the original DM message with the participants that have joined. That would be a way to avoid multiple notifications. That would need to max out after more 3 participants join. For example,

• Jim and Alice have joined the meeting before you
• Jim, Alice, and Frank have joined the meeting before you
• Jim, Alice, Frank, and X more have joined the meeting before you.

The host has joined the meeting: We added the logic to show a similar message when we created the PR but it was remove later because of this comment. Please let us know if we should add it back.

Thanks @raghavaggarwal2308 - I completely forgot I made that comment. I'm aligned to the original comment, no need to bring it back. Could you remove this from the PR description?

[mickmister]

I'm thinking we'll want a clear way for users to opt-out of this feature. Also note that this was a suggestion from a previous PM and not direct ask from a customer. @raghavaggarwal2308 What do you think about the remaining work and potential maintenance costs of the feature?

[raghavaggarwal2308]

I'm thinking we'll want a clear way for users to opt-out of this feature. Also note that this was a suggestion from a previous PM and not direct ask from a customer. @raghavaggarwal2308 What do you think about the remaining work and potential maintenance costs of the feature?

@mickmister It will take some time to explore and apply the suggestion given by @matthewbirtch . Also, once the PR is completed and merger, I think there might be some suggestions from users.

[raghavaggarwal2308]

@wiggin77 Do you think we should continue our work on this PR?