mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[MM-133] Added a feature of restricting bot messages to private channels and DM/GMs #337

Closed ayusht2810 closed 1 day ago

ayusht2810 commented 8 months ago

Summary

Ticket Link

79

Screenshots

image image image image

What to test?

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 41.22807% with 134 lines in your changes missing coverage. Please review.

Project coverage is 16.56%. Comparing base (d73eafa) to head (2549a1e). Report is 8 commits behind head on master.

:exclamation: Current head 2549a1e differs from pull request most recent head 5ff77f7

Please upload reports for the commit 5ff77f7 to get more accurate results.

Files Patch % Lines
server/command.go 9.90% 100 Missing :warning:
server/http.go 76.82% 15 Missing and 4 partials :warning:
server/store.go 57.14% 12 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #337 +/- ## ========================================== - Coverage 18.04% 16.56% -1.49% ========================================== Files 9 9 Lines 1546 1733 +187 ========================================== + Hits 279 287 +8 - Misses 1216 1407 +191 + Partials 51 39 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raghavaggarwal2308 commented 6 months ago

@ayusht2810 Please resolve conflicts

raghavaggarwal2308 commented 6 months ago

@mickmister Gentle reminder for review

ayusht2810 commented 4 months ago

@mickmister Gentle reminder to review the PR

Kshitij-Katiyar commented 3 months ago

LGTM 👍 just some non-blocking comments for discussion

For the markdown table in the channel-settings list response, we should probably have it say:

Default: Allow meetings in public channels, private channels, and DMs/GMs

or

Default: Allow meetings only in private channels and DMs/GMs

then simply omit any rows from the table that have the "default" value. We could probably just remove that channel from the saved settings map if the user chooses "default". 0/5 on this though

@mickmister the default setting has a dynamic value (i.e. it can be updated in plugin configuration) Screenshot from 2024-06-06 18-06-05 Didn't get you on this, please explain.

mickmister commented 3 months ago

@mickmister the default setting has a dynamic value (i.e. it can be updated in plugin configuration) Screenshot from 2024-06-06 18-06-05 Didn't get you on this, please explain.

@Kshitij-Katiyar Yes I was suggesting we display this value in the response in the wording I posted above. Just so when someone wants to inspect the settings on a channel, they can know what the default value is. Then we can omit any channels that are either unassigned or using the default value

Kshitij-Katiyar commented 3 months ago

Default: Allow meetings only in private channels and DMs/GMs

this was the existing channel setting list channel setting zoom old

And this is the updated channel setting list channel setting configuraiton new

@mickmister I hope this aligns with your suggestions. Please let us know if anything else is required.

raghavaggarwal2308 commented 2 months ago

@fmartingr Gentle reminder for review

raghavaggarwal2308 commented 2 months ago

@mickmister Fixed the review comments added by you

ayusht2810 commented 2 months ago

@AayushChaudhary0001 Fixed the above use case. Can you please re-test the PR?

raghavaggarwal2308 commented 1 week ago

@wiggin77 Can you please review this PR. Its already approved but we need a codeowner's approval for merging

raghavaggarwal2308 commented 1 week ago

@wiggin77 Fixed the review comments added by you, please re-review

raghavaggarwal2308 commented 1 week ago

@wiggin77 Updated. Please re-review