search

mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

[MM-191] Added typescript setup #342

Closed raghavaggarwal2308 closed 5 months ago

raghavaggarwal2308 commented 6 months ago

Summary

Ticket Link

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 18.41%. Comparing base (7fa5345) to head (c3f6dd9).

:exclamation: Current head c3f6dd9 differs from pull request most recent head 8ebc9e4. Consider uploading reports for the commit 8ebc9e4 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #342 +/- ## ========================================== - Coverage 18.47% 18.41% -0.07% ========================================== Files 9 9 Lines 1510 1515 +5 ========================================== Hits 279 279 - Misses 1180 1185 +5 Partials 51 51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

raghavaggarwal2308 commented 6 months ago

@ayusht2810 Fixed the review comments added by you

mickmister commented 5 months ago

@raghavaggarwal2308 There are conflicts to resolve here

raghavaggarwal2308 commented 5 months ago

@mickmister I think @ayusht2810 has alredy added the typescript setup here https://github.com/mattermost/mattermost-plugin-zoom/pull/333. Thoughts on closing this PR?