search

mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:
Apache License 2.0
107 stars 68 forks source link

The already started meeting is not aware of if the meeting stared in the last 30 seconds has ended #373

Open raghavaggarwal2308 opened 4 months ago

raghavaggarwal2308 commented 4 months ago

More information here: https://community.mattermost.com/core/pl/xh1k4upb6ff8jni8cuzeyw9wqy

Steps to reproduce:

  1. Start a zoom meeting in a channel.
  2. End the above meeting and try to start a new meeting within 30 seconds.

Expected behavior: A new meeting is started

Current behaviour: Getting a post with the message that a meeting was recently created in the channel.

Kshitij-Katiyar commented 1 month ago

@mickmister @wiggin77 when a meeting-ended notification is received from the webhook, we update the post's meeting_status prop. If we add the following check in the checkPreviousMessage function, we can resolve this issue.

meetingStatus := getString("meeting_status", post.Props)
if meetingStatus == zoom.WebhookStatusEnded {
    continue
}

However, this fix has one limitation: it will only work if the user has successfully set up the webhook.

Is this approach fine? Should we go ahead and implement this?

mickmister commented 1 month ago

However, this fix has one limitation: it will only work if the user has successfully set up the webhook.

@Kshitij-Katiyar The core feature depends on the webhook anyway right? Sounds good to me :+1: