Fix issue of zoom settings command being ignored after connecting user

mattermost / mattermost-plugin-zoom

Zoom plugin for Mattermost :electric_plug:

Apache License 2.0

107 stars 68 forks source link

Fix issue of zoom settings command being ignored after connecting user #385

Closed ayusht2810 closed 1 month ago

ayusht2810 commented 1 month ago

Summary

Fixed issue of zoom settings command being ignored after connecting user

Ticket Link

Fixes #345

What to test?

Zoom Settings are being checked after connecting of the user

Checklist

[x] Completed dev testing
[x] make test Ran test cases and ensured they are passing
[x] make check-style Ran style check and ensured both webapp and server pass the checks

Demo

screen-capture (9).webm

ayusht2810 commented 1 month ago

@mickmister @raghavaggarwal2308 fixed the review fixes. Please re-review

ayusht2810 commented 1 month ago

@mickmister fixed the review comment. Please re-review

raghavaggarwal2308 commented 1 month ago

@mickmister Fixed the review comments added by you

mickmister commented 1 month ago

@ayusht2810 Does this need QA review or do you think this is good to merge?

ayusht2810 commented 1 month ago

@mickmister The PR is ready for merge but it can't be merged now as @wiggin77 review is still pending as code owner. Meanwhile, @AayushChaudhary0001 can also give the PR a quick test, if he wants to.