search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Fix createComplianceReport action parameter type #1289

Closed daniel-shuy closed 3 years ago

daniel-shuy commented 3 years ago

Summary

The mattermost-server [POST /compliance/reports] (https://github.com/mattermost/mattermost-server/blob/v5.28.1/api4/compliance.go#L23) API expects a Compliance (see ComplianceFromJson()), but the mattermost-redux createComplianceReport() action takes in a Job instead of a Compliance.

Ticket Link

mattermod commented 3 years ago

Hello @daniel-shuy,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

jgilliam17 commented 3 years ago

@jfrerich Is there a way to create a test server for redux pr? Od should I test this after merge? Thanks.

jfrerich commented 3 years ago

Personally, I think this is fine to test post merge. I'm not positive how one would create a test server for a redux PR

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

jasonblais commented 3 years ago

@jfrerich or @hanzei are you open to help with merging this PR? Thanks!