search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

[GH-1290] Update isomorphic-fetch to 3.0.0 and make it a dev dependency #1308

Closed sbley closed 3 years ago

sbley commented 3 years ago

Summary

This pull request updates to the latest version of isomorphic-fetch (3.0.0) which resolves a security vulnerability. It also moves isomorphic-fetch to the devDependencies because the library is only used for testing purposes.

Ticket Link

Fixes https://github.com/mattermost/mattermost-redux/issues/1290

mattermod commented 3 years ago

Hello @sbley,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Willyfrog commented 3 years ago

@hmhealey this doesn't need QA review, right? I see it was moved to devdependencies

hmhealey commented 3 years ago

Yeah, that's correct. It's only used for unit tests.