search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

[MM-27927] - Add user preference for limit on dms and gms #1310

Closed nevyangelova closed 3 years ago

nevyangelova commented 3 years ago

There is an error with category sorting, when you are currently on a DM which gets sorted last (or in between the last messages) alphabetically, the DM will disappear when you limit the view count (from 20 to 10 for example)

hmhealey commented 3 years ago

Also, could you add a test case for this case if it's not too difficult to recreate that state?

nevyangelova commented 3 years ago

Also, could you add a test case for this case if it's not too difficult to recreate that state?

there is a test case, but it checks for only one channel I would add a second one to recreate more accurately :P

hmhealey commented 3 years ago

Leaving this to merge once the webapp PR is ready so that we don't end up breaking master like we did last time.

nevyangelova commented 3 years ago

/update-branch

nevyangelova commented 3 years ago

I went with a different approach and sorted channels by unreads first and last_viewed_at second, and that determines the cutout.

nevyangelova commented 3 years ago

/update-branch