I went through a few versions of this trying to get the backwards compatibility correct, particularly when I was trying to make it cover both the old and new sidebars. I finally ended up removing the old sidebar from the selector since we're not going to change the old sidebar to use the new selector anyway.
For the new preference, we're using the show_unread_section preference which was previously used a long time ago in the earliest version of the sidebar revamp. Since we're going to be prioritizing that over the preference that was used in the mean time, there's a small chance that someone will have the original preference turned on but the current preference turned off, but I don't think that'll be a problem.
I went through a few versions of this trying to get the backwards compatibility correct, particularly when I was trying to make it cover both the old and new sidebars. I finally ended up removing the old sidebar from the selector since we're not going to change the old sidebar to use the new selector anyway.
For the new preference, we're using the
show_unread_sectionpreference which was previously used a long time ago in the earliest version of the sidebar revamp. Since we're going to be prioritizing that over the preference that was used in the mean time, there's a small chance that someone will have the original preference turned on but the current preference turned off, but I don't think that'll be a problem.Ticket Link
https://mattermost.atlassian.net/browse/MM-30443
Related Pull Requests
https://github.com/mattermost/mattermost-webapp/pull/7293