search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

add new field in userstatus type #1329

Closed darkLord19 closed 3 years ago

darkLord19 commented 3 years ago

Redux changes for mattermost/mattermost-server#15640 and mattermost/mattermost-server#16067

mattermod commented 3 years ago

Hello @darkLord19,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

reflog commented 3 years ago

Do not merge until https://github.com/mattermost/mattermost-server/pull/16067 is done

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

mattermod commented 3 years ago

This PR has been automatically labelled "stale" because it hasn't had recent activity. A core team member will check in on the status of the PR to help with questions. Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

hmhealey commented 3 years ago

Webapp PR: https://github.com/mattermost/mattermost-webapp/pull/7037

hmhealey commented 3 years ago

@darkLord19 We're going to be shortly deprecating mattermost-redux as a standalone repository and moving it into mattermost-webapp as part of an effort to make development of both codebases easier by using a monorepo. This is going to require either merging or closing all outstanding pull requests in this repository in preparation for the migration planned for tomorrow.

For this PR, it looks like it can't be merged into master immediately because it will require changes in the web app to add the new field to existing objects, so it'll have to be closed and resubmitted against mattermost-webapp separately. You can do that yourself if you'd like, or we could help with that instead. The easiest way to do that would probably be to integrate them into https://github.com/mattermost/mattermost-webapp/pull/7037 after the migration is done.

darkLord19 commented 3 years ago

@hmhealey thanks for the heads up. If you need you can close this PR. I will raise new PR against webapp repo.

hmhealey commented 3 years ago

I'll let you know when that can be done. The migration is a bit behind schedule, but it will still be happening in the next day or two.

hmhealey commented 3 years ago

@darkLord19 Thanks for waiting on that. mattermost-redux now lives here, so you can add these changes to your webapp PR.