mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Temporarily fix typing issues #1333

Closed hmhealey closed 3 years ago

hmhealey commented 3 years ago

The TypeScript compiler is failing to type check the web app with the current master. There are two things causing problems currently:

  1. There are a couple circular references, one caused by types importing constants and vice versa and the other caused by two type files importing each other. I resolved the first one, but I wasn't able to resolve the second, so I just turned it to an any temporarily.
  2. Some unit tests in the web app are failing because the Post.participants field was previously mandatory. This can be reverted if necessary.