search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Custom status feature #1349

Closed chetanyakan closed 3 years ago

chetanyakan commented 3 years ago

Summary

Ticket Link

mattermod commented 3 years ago

Hello @chetanyakan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

esethna commented 3 years ago

Test server from brightscout that includes webapp, redux and server changes: http://ec2-3-137-148-232.us-east-2.compute.amazonaws.com:8065/signup_user_complete/?id=559fit8sj7bm8n7mcpqcz9cy5y

chetanyakan commented 3 years ago

@reflog

Here, we just make the API call to update the user's custom status. In the server, in the API implementation, we update the user's props with the current status.

Following that, any update to any User is sent to all logged-in users via the WebSocket events. In the web-app, we just use the updated values of the user props to show the custom status set by that user.

This implementation follows the one suggested by @jespino here: https://mattermost.atlassian.net/wiki/spaces/CS/pages/1096810497/Development+Spec

reflog commented 3 years ago

@chetanyakan - sounds reasonable, thanks!

chetanyakan commented 3 years ago

Rebased to the HEAD of master

esethna commented 3 years ago

@hmhealey can you help with reviews here and on the webapp PR as needed? We're hoping to merge this for the v5.32 deadline (early next week)

chetanyakan commented 3 years ago

Rebased to the HEAD of master.

chetanyakan commented 3 years ago

Rebased to the HEAD of master.

amyblais commented 3 years ago

/cherry-pick cloud

mattermod commented 3 years ago

Cherry pick is scheduled.