search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

MM-18902 Removed unused status flags from Roles request #1367

Closed djanda97 closed 3 years ago

djanda97 commented 3 years ago

Summary

Fixes https://github.com/mattermost/mattermost-server/issues/12520

Ticket Link

Related PR (webapp): https://github.com/mattermost/mattermost-webapp/pull/7562

mattermod commented 3 years ago

Hello @djanda97,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

djanda97 commented 3 years ago

There was an existing PR https://github.com/mattermost/mattermost-redux/pull/942 that went stale, so I tried basing this PR off of the feedback given there.

reflog commented 3 years ago

@djanda97 - thanks for your contribution! Please address the failing unit tests

hmhealey commented 3 years ago

@djanda97 We're going to be shortly deprecating mattermost-redux as a standalone repository and moving it into mattermost-webapp as part of an effort to make development of both codebases easier by using a monorepo. This is going to require either merging or closing all outstanding pull requests in this repository in preparation for the migration planned for tomorrow.

Since there's outstanding issues with the PR by the sounds of it, we're going to have to close this PR and reopen it in the webapp repo once that migration is done. I can help with that if you'd like, so let me know what you'd like to do with this.

djanda97 commented 3 years ago

@hmhealey I'm glad to hear that these repos are combining! Closing this PR for now is good with me, I can try re-opening once the monorepo is ready.

hmhealey commented 3 years ago

Sounds good. We're slightly behind schedule on that, but I can definitely post back when that's ready.

hmhealey commented 3 years ago

@djanda97 Thanks for waiting on that. mattermost-redux now lives here, so you can resubmit your changes against that. You might be able to just copy and paste these files over top of those ones, but be aware that there might be some conflicts that need to be resolved.