search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

MM-33209 Downgrade serialize-error #1372

Closed hmhealey closed 3 years ago

hmhealey commented 3 years ago

The Selenium tests that QA use run on Firefox 54, and the new version of serialize-error fails to load on there because it uses slightly newer syntax (https://caniuse.com/mdn-javascript_statements_try_catch_optional_catch_binding, supported in Firefox 58+). Selenium will be upgraded or removed at some point, but this will fix it in the meantime.

Ticket Link

https://mattermost.atlassian.net/browse/MM-33209

Related Pull Requests

https://github.com/mattermost/mattermost-webapp/pull/7586

mattermod commented 3 years ago

Cherry pick is scheduled.

mattermod commented 3 years ago

Error trying doing the automated Cherry picking. Please do this manually

+++ Updating remotes...
Fetching upstream
Failed to add the RSA host key for IP address '140.82.114.3' to the list of known hosts (/app/.ssh/known_hosts).
From github.com:mattermost/mattermost-redux
 * [new branch]        MM-20441_call-path     -> upstream/MM-20441_call-path
   4c6af352..757cc488  MM-32655               -> upstream/MM-32655
 * [new branch]        MM-32691               -> upstream/MM-32691
   f0a679c2..43723c72  SectionsToSubSections  -> upstream/SectionsToSubSections
   0bac39f5..3599510c  cloud                  -> upstream/cloud
   de420382..e82ee2e5  feature/cloud-apps     -> upstream/feature/cloud-apps
 * [new branch]        fix_feature/cloud-apps -> upstream/fix_feature/cloud-apps
   041dc987..e0bc76cd  master                 -> upstream/master
Fetching origin
Failed to add the RSA host key for IP address '140.82.114.3' to the list of known hosts (/app/.ssh/known_hosts).
+++ Updating remotes done...
!!! 'upstream/release-5.33' not found. The second argument should be something like upstream/release-0.21.
    (In particular, it needs to be a valid, existing remote branch that I can 'git checkout'.)

+++ Returning you to the master branch and cleaning up.
hmhealey commented 3 years ago

/cherry-pick cloud

mattermod commented 3 years ago

Cherry pick is scheduled.