search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

MM-24009: remove redux-action-buffer #1393

Closed lieut-data closed 3 years ago

lieut-data commented 3 years ago

Summary

This is a precursor to removing redux-offline altogether, by noting first that redux-action-buffer is only used when enableBuffer is left unset or passed as true, but the webapp unconditionally passes it as false:

https://github.com/mattermost/mattermost-webapp/blob/8676ca150396b1eed898d7a114264bfa4278e884/store/index.js#L215

Ticket Link

Relates-to: https://mattermost.atlassian.net/browse/MM-24009

lieut-data commented 3 years ago

@hmhealey, I'd love to get a sanity check on my investigation here. From what I can see, this code path was only ever used by the mobile app, but of course their having diverged from mattermost-redux proper, we no longer need this.

hmhealey commented 3 years ago

Yeah, that looks right to me. It looks like it was used to hold any redux actions until the state was finished rehydrating from disk, but that only really mattered on the mobile app where everything is saved to disk.

hmhealey commented 3 years ago

This can be tested in the corresponding web app PR