search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

MM-24009: remove redux-offline #1396

Closed lieut-data closed 3 years ago

lieut-data commented 3 years ago

Summary

Follow the lead of https://github.com/mattermost/mattermost-mobile/pull/4120 and remove redux-offline. The library was responsible for automatically retrying select requests, but the vast majority of API calls remained unaffected. Removing the library simplifies the surface area of the Redux store and corresponding code. Note that this library is discrete from redux-persist, currently responsible for the magic of storage.storage and rehydrating previously saved drafts, etc.

I've broken this PR into various discrete PRs that are worth reviewing independently. But to summarize the other changes that were tangled with removing this library:

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-24009

Also, see https://github.com/mattermost/mattermost-webapp/pull/7648

lieut-data commented 3 years ago

/update-branch

hmhealey commented 3 years ago

@jgilliam17 This has to be reviewed in the corresponding webapp PR

hmhealey commented 3 years ago

@lieut-data I've added the Awaiting PR label since if this goes in first and someone updates their version of mattermost-redux in the webapp, then it'll break due to the change in parameters. One of the many reasons I'm looking forward to getting rid of mattermost-redux

lieut-data commented 3 years ago

Re-requesting dev review given the changes. Might be easiest to review with whitespace diff disabled. See https://github.com/mattermost/mattermost-webapp/pull/7648#issuecomment-797692291 for context.

tkiethanom commented 2 years ago

It doesn't look like this change was pushed to the npm version 5.33.1. I'm still seeing redux-offline in the dependencies list.