search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Remove async/await and some mocks from tests #1408

Closed hmhealey closed 3 years ago

hmhealey commented 3 years ago

async/await and this mocking seemed to cause issues after this was moved into the web app. I'm not 100% sure that these will solve those issues, but they seem decent enough to clean up anyway.

lieut-data commented 3 years ago

To confirm, are all these async / await spurious, in that none of the methods return promises?

hmhealey commented 3 years ago

I think we could've used a promise somewhere, but it doesn't seem necessary any more at least. I'd prefer to simplify things by removing the async/awaits wherever is possible since it makes integrating the tests with the webapp code easier.