search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Changed the method to POST in removeRecentCustomStatus API call #1409

Closed chetanyakan closed 3 years ago

chetanyakan commented 3 years ago

Summary

Ticket Link

Related PR: https://github.com/mattermost/mattermost-server/pull/17122

mattermod commented 3 years ago

Hello @chetanyakan,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

nevyangelova commented 3 years ago

Hello @chetanyakan do we have a green light from server team to merge this? If so this PR needs to wait for that PR to go in as well. Otherwise LGTM

hmhealey commented 3 years ago

@chetanyakan We're going to be shortly deprecating mattermost-redux as a standalone repository and moving it into mattermost-webapp as part of an effort to make development of both codebases easier by using a monorepo. This is going to require either merging or closing all outstanding pull requests in this repository in preparation for the migration planned for tomorrow.

Since this is waiting on server changes, we'll probably have to close it and reopen in the webapp repo once that migration is done. I can help doing that if you'd like, but either way on that, I'll let you know when this can be reopened after that migration is done.

hmhealey commented 3 years ago

As mentioned above, I'm going to close this for now. We can continue testing the server changes with this branch for the time being, but I'll let you know when you can resubmit this against the webapp repo.

hmhealey commented 3 years ago

@chetanyakan Thanks for waiting on that. mattermost-redux now lives here, so you can resubmit your changes over there.