search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

Add NoAccounts property to ClientConfig type #1410

Closed EricMontague closed 3 years ago

EricMontague commented 3 years ago

Summary

This PR adds the NoAccounts property to the ClientConfig type alias. While migrating the SignupEmail component to Typescript in the webapp repo, I discovered that this property wasn't present on the ClientConfig type.

Ticket Link

N / A

mattermod commented 3 years ago

Hello @EricMontague,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

devinbinnie commented 3 years ago

So this field was added in this PR just today: https://github.com/mattermost/mattermost-redux/pull/1412 Not sure if we need this change, though I do like that we restrict the field to just a stringified boolean.

hmhealey commented 3 years ago

I think it's safe to close this then. We can always make the the typing stricter later if wanted, but that one solves the main problem here.

@EricMontague If you could update your webapp PR to the latest master and its mattermost-redux version, everything should work then.

EricMontague commented 3 years ago

I think it's safe to close this then. We can always make the the typing stricter later if wanted, but that one solves the main problem here.

@EricMontague If you could update your webapp PR to the latest master and its mattermost-redux version, everything should work then.

Okay I pulled in the changes from master into my branch and pointed it the main mattermost-redux repo.