search

mattermost / mattermost-redux

Redux for Mattermost
Apache License 2.0
200 stars 386 forks source link

[GH_16717/MM_20389] Migrate 'components/signup/signup_controller' module and associated tests to TypeScript #1412

Closed aggmoulik closed 3 years ago

aggmoulik commented 3 years ago

Signed-off-by: Moulik Aggarwal qwertymoulik@gmail.com

Summary

It changes the name of the SubscriptionStats in camelcase as it was written in bad mannered and added a property which is used in the react web app.

Ticket Link

Fixes: https://mattermost.atlassian.net/browse/MM-20389

mattermod commented 3 years ago

Hello @aggmoulik,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

aggmoulik commented 3 years ago

@lieut-data I can remove the eslint rule in the same PR of webapp.

aggmoulik commented 3 years ago

Hy @lieut-data @devinbinnie , I have removed the naming in redux and also fixed the web-app PR. So, please review this so that web-app PR can pass all checks.

lieut-data commented 3 years ago

Weird, my comment didn't actually show up -- the ask was to sort the new entry alphabetically with the rest.

aggmoulik commented 3 years ago

Weird, my comment didn't actually show up -- the ask was to sort the new entry alphabetically with the rest.

Updated @lieut-data