change patchChannel to accept a partial Channel

mattermost / mattermost-redux

Redux for Mattermost

Apache License 2.0

200 stars 386 forks source link

change patchChannel to accept a partial Channel #1424

Closed Crimson-riot closed 3 years ago

Crimson-riot commented 3 years ago

Summary

Updates patchChannel to accept a partial channel instead of a full channel, as patchChannel is only ever called with a partial channel in mattermost-webapp (specifically in edit_channel_purpose_modal).
Is required for https://github.com/mattermost/mattermost-webapp/pull/8042

Ticket Link

Addresses https://github.com/mattermost/mattermost-server/issues/16714

mattermod commented 3 years ago

Hello @Crimson-riot,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hmhealey commented 3 years ago

Sorry about the delay, @Crimson-riot. We haven't been monitoring this repo for pull requests lately since we're currently in the process of deprecating it in favour of having mattermost-redux included in the new mattermost-webapp monorepo, so we're not merging any more PRs here.

Since you already have a webapp PR, you can actually add these changes to it instead of needing two PRs. The files for mattermost-redux are now under packages/mattermost-redux in the web app repo.

Crimson-riot commented 3 years ago

Ah ok i'll put it in there, sorry about that!