search

mattermost / mattermost

Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..
https://mattermost.com
Other
30.23k stars 7.23k forks source link

MM-44470 - Chrome won't display SVG files in img tags, if they don't have width and height defined #20271

Open mattermod opened 2 years ago

mattermod commented 2 years ago

Upload any svg file that doesn’t have width and height defined in the <svg> tag

Observed:

the image is not showing on Chrome/Safari browsers. neither in channel (shows on Firefox) nor in file preview modal

Expected:

The image should show both in channel and in file preview modal

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-44470

thinkGeist commented 2 years ago

This looks interesting, I'd like to take a stab at fixing this if nobody else has picked it up.

jbattistispiria commented 2 years ago

@thinkGeist I almost finish to fix this issue. Sorry, i forgot to say i'm on it.

jbattistispiria commented 2 years ago

@mattermod I'll take this one.

dkretz-spiria commented 1 year ago

@amyblais this ticket is up for grabs again. @jbattistispiria is no longer working on this ticket.

elYanuki commented 9 months ago

@thinkGeist you can have it now 👀