mattermost / mattermost

Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..
https://mattermost.com
Other
30.25k stars 7.24k forks source link

Migrate /enterprise/saml e2e tests to TypeScript #21316

Open mattermod opened 1 year ago

mattermod commented 1 year ago

Converting following spec files under /integration/enterprise/saml to Typescript

  1. okta_login_spec.js
  2. saml_automated_spec.js
  3. saml_guest_member_spec.js
  4. saml_metadata_spec.js

Below is a checklist of items you should be doing to migrate:

  1. Rename the files to their associated TypeScript extensions (ie. js to ts)
  2. Move over all the types from the declaration (d.ts) files into the matching typescript file, and delete the declaration file (see Support Migration PR link below for reference )

  1. Fix any errors generated by the TypeScript compiler.

    • Navigate to /e2e/cypress and run npm run check-types to display any errors.
  2. Run

/e2e-run from PR and make sure all migrated and existing tests are passed. Automation results can be seen here Automation Dashboard

Note:

References

📗 Suport Files Migration Reference

Support Migration PR

📘 Spec File Migration Reference

account_settings/profile tests migration PR


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-47312

TomerPacific commented 1 year ago

Hey @mattermod , I'd like to help out with this.

TomerPacific commented 1 year ago

Thanks @amyblais . Working on setting up my local development environment. I'll keep you updated if I run into any issues or if I need any guidance.

TomerPacific commented 1 year ago

@amyblais , currently stuck on step 4 from here:

sudo apt-get install -y build-essential
sudo rm -rf /usr/local/go
wget https://dl.google.com/go/go$VERSION.$OS-$ARCH.tar.gz /// <---- HERE
sudo tar -C /usr/local -xzf go$VERSION.$OS-$ARCH.tar.gz

Inside WSL, when I run the command like so:

wget https://dl.google.com/go/go1.19.2.linux-amd64.tar.gz

I get: mattermost

Any idea how I can overcome this?

amyblais commented 1 year ago

cc @furqanmlk ^

TomerPacific commented 1 year ago

@amyblais - Might be worthwhile to unassign me and let someone else take this issue.

furqanmlk commented 1 year ago

@amyblais , currently stuck on step 4 from here:


sudo apt-get install -y build-essential

sudo rm -rf /usr/local/go

wget https://dl.google.com/go/go$VERSION.$OS-$ARCH.tar.gz /// <---- HERE

sudo tar -C /usr/local -xzf go$VERSION.$OS-$ARCH.tar.gz

Inside WSL, when I run the command like so:

wget https://dl.google.com/go/go1.19.2.linux-amd64.tar.gz

I get:

mattermost

Any idea how I can overcome this?

Hi @TomerPacific Sorry for the delay. Can we setup zoom call to solve this issue. What OS are you using?

TomerPacific commented 1 year ago

Hi @furqanmlk, thanks for replying. I am on Windows and have followed the instructions for setting up a local development environment. Once I downloaded and set up WSL, I ran all the steps inside there. Not sure when will be a good time to set up a zoom call. We have a seven hour time difference between us.

What could be the cause of the error I am seeing?

furqanmlk commented 1 year ago

Hi @furqanmlk, thanks for replying.

I am on Windows and have followed the instructions for setting up a local development environment.

Once I downloaded and set up WSL, I ran all the steps inside there.

Not sure when will be a good time to set up a zoom call.

We have a seven hour time difference between us.

What could be the cause of the error I am seeing?

Can you please join Mattermost community https://community.mattermost.com ? We have developers channel there for contributor's help and questions. Please let me know if you see difficulty to join.

chaiwattsw commented 1 year ago

I would like to take this issue please assign to me

hereje commented 19 hours ago

I would like to work on this issue!