Unread direct message stays after user deletion

mattermost / mattermost

Mattermost is an open source platform for secure collaboration across the entire software development lifecycle..

https://mattermost.com

Other

30.45k stars 7.29k forks source link

Unread direct message stays after user deletion #22781

Open dwaxweiler opened 1 year ago

dwaxweiler commented 1 year ago

Summary

The direct message of a deleted user stays as unread.

Steps to reproduce

User A sends a direct message to user B.
User B reads the direct message.
User B marks the direct message as unread.
User A is deleted.

Maybe, steps 2 and 3 are not even necessary, but I have not test environment for trying this.

Expected behavior

User B sees nothing of user A after user A is deleted.

Observed behavior (that appears unintentional)

User B sees the notification "More unreads" in the left sidebar.
User B scrolls down and sees an empty line in direct message list:
Nothing happens if you click on that line.
No options (three dots) are shown on that line on hover.

amyblais commented 1 year ago

@dwaxweiler What Mattermost server version are you on?

dwaxweiler commented 1 year ago

@amyblais I discovered the issue in version 7.7.1, and it is still visible after upgrading to version 7.9.1.

amyblais commented 1 year ago

Thanks, opened https://mattermost.atlassian.net/browse/MM-51983.

sinansonmez commented 1 year ago

@dwaxweiler I am trying to replicate and fix the issue. However I was not able to replicate it on my local. I deactivated the user but I am still seeing the message with archived icon under Direct Messages. Do you mean something different by user deleted than user deactivated?

larkox commented 1 year ago

@dwaxweiler How are you deleting the user? Hard delete through mmctl or the database?

As @sinansonmez pointed, this should not happen if the user is deactivated (the "correct" way to delete users). If you refresh the web app, does it get fixed?

dwaxweiler commented 1 year ago

@sinansonmez @larkox I deleted the user using mmctl, but I don't remember whether I deactivated them first or not.

Refreshing the web application did not help back then, but I could remove this chat via the Android app.

sinansonmez commented 1 year ago

@larkox any suggestion on how to replicate this?

larkox commented 1 year ago

@sinansonmez This would be my guess:

Have user A and user B in the system
DM from user B to user A
From the phone, confirm on user A that the DM exist (leave it unread just in case)
Use mmctl to hard delete user B
Open the phone app as user A

That should reproduce it, but not 100% sure.