Status Follow/Unfollow thread incorrect

vanha-bic commented 1 year ago

Per Mattermost guidelines, GitHub issues are for bug reports: https://handbook.mattermost.com/contributors/contributors/ways-to-contribute/.

For troubleshooting see: https://forum.mattermost.com/. For feature proposals see: https://mattermost.com/suggestions/

If you've found a bug--something appears unintentional--please follow these steps:

Confirm you’re filing a new issue. Search existing tickets in Jira to ensure that the ticket does not already exist.
Confirm your issue does not involve security. Otherwise, please see our Responsible Disclosure Policy.
File a new issue using the format below. Mattermost will confirm steps to reproduce and file in Jira, or ask for more details if there is trouble reproducing it. If there's already an existing bug in Jira, it will be linked back to the GitHub issue so you can track when it gets fixed.

Summary

When follow or unfollow and reload page status of them don't change

Steps to reproduce

Any mattermost version. i test on comunity

Follow/Unfollow topics and reload the page. try a few times and look at the status will see that the status is not correct

Expected behavior

Follow/Unfollow topics and reload the page. Status should be correct

Observed behavior (that appears unintentional)

What did you see happen? Please include relevant error messages and/or screenshots.

Possible fixes

If you can, link to the line of code that might be responsible for the problem

amyblais commented 1 year ago

Hi @vanha-bic, can you help share more details on what you mean by "status of them don't change"? Can you help share a screenshot of what you're seeing?

vanha-bic commented 1 year ago

@amyblais I mean status follow of thread don't change. you can see it on under video

https://github.com/mattermost/mattermost/assets/129161603/2bfe2c7c-6d9f-4da1-a527-93e669c8d127

FellipeMTX commented 1 year ago

@amyblais I tested it and it is really a bug, can I pick it up?

vanha-bic commented 1 year ago

@FellipeMTX I've looked into the cause and the fix, but I'm not sure it is a good idea. Maybe I will wait for pr from your side. Etag doesn't update after following or unfollow please see at: api4/post.go:306 Thank

amyblais commented 1 year ago

@vanha-bic I can create a ticket for PMs to review. Do you know if this is a new issue on community, or have you seen this issue on previous versions of Mattermost?

vanha-bic commented 1 year ago

@amyblais I think it's been around for a long time. at least from version 7.0 (I tested on it)

amyblais commented 1 year ago

Opened a ticket for review: https://mattermost.atlassian.net/browse/MM-53429.

tasduq commented 1 year ago

Hey @amyblais I am interested in solving this issue. Kindy can you assign it to me? Thanks

amyblais commented 1 year ago

@tasduq Our devs noted that this issue is a symptom of a bigger cache issue, so we don't want to assign this to community members at this point.

devinbinnie commented 1 year ago

@amyblais @tasduq Sorry, this ticket is missing some context. We actually tried to solve this ourselves in a couple PRs here: https://github.com/mattermost/mattermost/pull/24505 https://github.com/mattermost/mattermost/pull/23948

This is a symptom of a greater issue with caching post metadata (including in this case, thread membership) in which we are serving out of date data. There is a thread in Mattermost Community to follow here if you want additional context: https://community.mattermost.com/core/pl/7pfxwi33wbrcxnnq7hyqiqizir

mattermost / mattermost