Closed mattermod closed 2 weeks ago
I want to contribute to this!
Awesome, thanks @abhisenberg :+1:
There is any progress? I would grab this issue if no one is working on it. @hanzei @abhisenberg @amyblais
if for you is ok I proceed with https://github.com/mattermost/mattermost/pull/27281#issuecomment-2161029136 @mickmister @hanzei , ok?
@willypuzzle Yes you are good :+1:
@mickmister should I clear the GetPluginID method out from Manifest (and the relative code) or can I keep it?
@willypuzzle The GetPluginID
method is a great improvementthat we should keep :+1:
@willypuzzle It seems this is already available through the pluginapi
package https://github.com/mattermost/mattermost/blob/1d704745b70dd1f92d6c89d70307d75f2b5fbb33/server/public/pluginapi/system.go#L23
I'm thinking we should close the issue as there is already a supported capability to get the plugin's id. @willypuzzle @fmartingr What do you think?
@willypuzzle It seems this is already available through the
pluginapi
package https://github.com/mattermost/mattermost/blob/1d704745b70dd1f92d6c89d70307d75f2b5fbb33/server/public/pluginapi/system.go#L23I'm thinking we should close the issue as there is already a supported capability to get the plugin's id. @willypuzzle @fmartingr What do you think?
Yes, I agree!
Closing due to GetManifest
already being implemented Thank you everyone for your work here.
Reopening as https://github.com/mattermost/mattermost/pull/27281 got reverted.
if you agree I can try again
Absolutely, go for it @willypuzzle! Please let me know if you need any help or clarification.
@hanzei should I add GetPluginId()
to API interface?
@willypuzzle Indeed. Please check out https://developers.mattermost.com/contribute/more-info/server/plugins/ for more details on how to add a new API method.
The plugin API should expose a method that allows plugins to fetch their own ID. While this method might not be useful on its own, it adds flexibility with writing higher-level helper methods like the ones found in the
pluginapi
packet. The method signature should beGetPluginID() string
.If you have any questions, please reach out to @hanzei either in this ticket or on the Mattermost Community server.
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-57738