search

mattermost / react-native-paste-input

React Native TextInput replacement to allow pasting files
MIT License
89 stars 15 forks source link

clear event is now available on iOS #13

Closed andres-torres-marroquin closed 1 year ago

andres-torres-marroquin commented 1 year ago

Fixes #12

Summary

Clear event is now available on iOS

Ticket Link

https://github.com/mattermost/react-native-paste-input/issues/12

mattermod commented 1 year ago

Hello @andres-torres-marroquin,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement? Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

larkox commented 1 year ago

Hi @andres-torres-marroquin I realized that two other functions are also not available on iOS: isFocused and getNativeRef. The getNativeRef I am not sure if needed, but would it be possible to add while you are at it, the isFocused one?

Dismiss this comment. Already handled in https://github.com/mattermost/react-native-paste-input/pull/15

larkox commented 1 year ago

Closing this as already handled in #15