suggested changes

[Avi-avidan]

Hi Waleed,

I have made a few changes to model.py, let me know if you want to me to push them -

• added imgaug augmentations (lines 1234-1267 in the file attached)
  • CropAndPad
  • translate_percent
  • scale
  • rotate
  • shear
  • added 'Adam' Optimizer (lines 2153-2160)
• added a change to 'build_fpn_mask_graph' so mask_shape is according to set in config.MASK_SHAPE (lines 2001, 2051, 951, 990-1000)
• renamed the 'detections' output (inference only) so it would be easier to deploy in production (using tf.serving) (lines 2053-2054)

thanks for this repo. It is great.

model.txt Best, Avi Avidan 0523385564

[waleedka]

Thanks, Avi.

Out of the items you listed, I think the optimizer is probably a common change that many people want to try. Even though the Mask RCNN paper, and other papers, recommend SGD over Adam.

However, if we're to make the optimizer a configuration option, then we'll have to make it generic. If it supports Adam and SGD only, then many will ask why other optimizers are not supported. And it should also include the optimizer parameters. Otherwise, if someone wants to change the decay of Adam then they have to change in two places: the config to choose Adam and the code to change the decay, and that's not very clean. If you have ideas on how to do this in a generic way, I'd be happy to review and merge it.

I didn't understand the need to rename the detections output? How does that help with tf.serving?