search

mattes / migrate

Database migrations. CLI and Golang library.
Other
2.29k stars 326 forks source link

Register neo4j driver using a pseudo `neo4js` protocol scheme. #216

Closed smulube closed 7 years ago

smulube commented 7 years ago

Neo4J supports both http and https connections, however https connections weren't supported previously as the neo4j URL scheme currently used to identify the driver type is always substituted for just http.

This PR also registers the driver under an alternate key: neo4js which given the way the scheme substitution happens, should allow the driver to correctly create an https connection URL. This will allow the library to be used for cases where we don't have access to the plain http endpoint.

mattes commented 7 years ago

Thanks!

smulube commented 7 years ago

ah, thanks for merging! was slightly uncomfortable that this was a bit of a hacky way of solving this, but it was pragmatically simple.

we may be interested in contributing an updated neo4j driver/database for the new branch but that all depends on how busy we are with other stuff - you know how it goes...

mattes commented 7 years ago

Of course! I understand! Ping me anytime if you want to chat or need help getting started.