Update cockroachDB Txn signatures

mattes / migrate

Database migrations. CLI and Golang library.

Other

2.29k stars 326 forks source link

Update cockroachDB Txn signatures #272

Closed taywrobel closed 7 years ago

taywrobel commented 7 years ago

cockroach-go made a backwards-incompatible change to their transaction function signatures, which was causing the cockroach instrumentation to fail.

Updates the signature to match the cockraoch-go change.

nexdrew commented 7 years ago

I can confirm that this fixes make test-short SOURCE='file' DATABASE='cockroachdb' when running against the latest commit of cockroachdb/cockroach-go, and it looks like they passed in the Travis build too.

I can also confirm that the CLI binary works with CockroachDB with this change (testing only on Mac so far).

Thanks @twrobel3!