search

mattes / migrate

Database migrations. CLI and Golang library.
Other
2.29k stars 326 forks source link

Add support for execution of multiple statements in one migration file #276

Open syndbg opened 7 years ago

syndbg commented 7 years ago

@mattes Just something that prevented us from using migrate initially.

syndbg commented 7 years ago

Note that I'll take a look at the failing tests and add/modify as needed.

mattes commented 7 years ago

Thanks for your PR. I think the tests are failing somewhere else actually. Need to investigate as well.

mattes commented 7 years ago

@JensRantil thanks for your PRs. I closed #280 in favor of this one. I'd much rather find a regex than introducing custom query markup. (Partially related: FAQ:why-two-separate-files)

@syndbg and @JensRantil thanks for bringing this up.

JensRantil commented 6 years ago

Any progress on how to handle strings with newlines? We are considering forking migrate internally and using https://github.com/mattes/migrate/pull/280 because of this.

syndbg commented 6 years ago

@JensRantil I totally slept on this PR. Give me a day and I'll finally address everything left.

syndbg commented 6 years ago

@JensRantil @mattes Updated and cleaned up. Cassandra tests still fail and I can't figure out. (note that they were failing before the changes too)

I had troubles getting them running locally, but I got this working eventually. Still I can't find why they're considered a FAIL.

emcfarlane commented 6 years ago

Any updates on merging this in?

syndbg commented 6 years ago

@afking It's quite stale. It was ready to merge in November 2017. Idk about now, it's probably obsolete/out-dated.

emcfarlane commented 6 years ago

@syndbg thanks, i've applied the changes locally.