search

mattes / migrate

Database migrations. CLI and Golang library.
Other
2.29k stars 326 forks source link

Made source.Up and source.Down the same type #327

Closed dcormier closed 6 years ago

dcormier commented 6 years ago

Changed source.Up from being an untyped string const to being a typed source.Direction const. This makes source.Up and source.Down the same type.

dhui commented 6 years ago

Fixed in the fork: https://github.com/golang-migrate/migrate/commit/395391525b2a64758726135624a70ea31b18949a

dcormier commented 6 years ago

Out of curiosity, why does that fork exist, @dhui? I don't see an explanation anywhere.

Ah, I see: #311.

dhui commented 6 years ago

Sorry, I didn't link the issue explaining why I forked the repo. Thanks for linking it!

dcormier commented 6 years ago

Closing as this is taken care of in the new maintained repo.