mattetti / Weasel-Diesel

DSL to describe, document and test web services
MIT License
438 stars 21 forks source link

implementing :doc in param definition #10

Closed ryfow closed 12 years ago

ryfow commented 12 years ago

Trying this again after a rebase.

This is the other end of mattetti/wd-sinatra#3

I know I have commit access to the repo, but I'd like someone to review before sticking it in master. Chances are that there's a better way to get that data into the documentation object.

mattetti commented 12 years ago

It looks great, I'll merge and since now that we have the CI working, we'll see if that causes an issue. I will update the examples to reflect this change. I will however, add a spec to make sure that the old format stays supported.

mattetti commented 12 years ago

Actually, the doc isn't copied over to api.doc.params_doc where api is a service object. To be more consistent, I'll fix that.

mattetti commented 12 years ago

wow, I'm just tired, I was in the process of implementing what I said wasn't working when I realized it was actually working. There is however, a problem with namespaces, but that's not directly related.