search

mattetti / Weasel-Diesel

DSL to describe, document and test web services
MIT License
438 stars 21 forks source link

Top Level Array Response Function #26

Closed dsshap closed 11 years ago

dsshap commented 11 years ago

Hi,

Any way we can get a release of the this gem with the top level array response functionality?

Or is there a hot fix I can implement in v1.2.1 that could get me this?

dsshap commented 11 years ago

I am also using a forked version of wd-sinatra, needed to set a version on minitest

mattetti commented 11 years ago

I'm confused, do you want me to release master as a new gem? I thought I didn't release the top level array response error yet.

dsshap commented 11 years ago

Hey, thanks for taking the time.

I was interested in seeing if you could release a new version of this gem, to include the top level array response ability. I am avoiding the error being thrown in my tests by not calling assert_api_response.

If you don't want to release it, what time line could one expect for a new release that includes the top level arrays supported in the json validation?

mattetti commented 11 years ago

If master doesn't currently work for you, I'm afraid I won't be able to add top level array response right away since I'm in the process of launching my startup :( If you just want me to cut a gem, I'd be glad to do so. Otherwise I'm afraid without a PR I won't be able to get that feature in any time soon.

On Mon, Aug 19, 2013 at 8:35 PM, Dave Shapiro notifications@github.comwrote:

Hey, thanks for taking the time.

I was interested in seeing if you could release a new version of this gem, to include the top level array response ability. I am avoiding the error being thrown in my tests by not calling assert_api_response.

If you don't want to release it, what time line could one expect for a new release that includes the top level arrays supported in the json validation?

— Reply to this email directly or view it on GitHubhttps://github.com/mattetti/Weasel-Diesel/issues/26#issuecomment-22920479 .

kamui commented 11 years ago

Maybe he's referring to #25? It looks like @raul added a PR for top level array response support.