search

mattetti / Weasel-Diesel

DSL to describe, document and test web services
MIT License
438 stars 21 forks source link

remove SinatraServiceController#logged_in? #32

Closed mikesea closed 10 years ago

mikesea commented 10 years ago

This should probably just be left to the client applications to implement themselves.

kamui commented 10 years ago

I believe the sinatra framework extensions in there are only used by the testing harness in the library. Last time I checked, I don't think wd-sinatra made use of any of that.

mikesea commented 10 years ago

@kamui well, then I'll leave it up to you whether to merge this or not. :) At present, it's an untested method that is not used by the testing harness. I'd vote to just remove it, or move the framework extensions into the spec library to better highlight that they're only used by the tests.

kamui commented 10 years ago

I think most of those specs revolve around controller_dispatch which appears to be deprecated. So it might even make sense to remove those specs and the framework_ext code.

mattetti commented 10 years ago

Agreed On Sep 12, 2013 2:27 AM, "Jack Chu" notifications@github.com wrote:

I think most of those specs revolve around controller_dispatch which appears to be deprecated. So it might even make sense to remove those specs and the framework_ext code.

— Reply to this email directly or view it on GitHubhttps://github.com/mattetti/Weasel-Diesel/pull/32#issuecomment-24297583 .

mikesea commented 10 years ago

I'll send a PR for that then.